Hi Petr, The fix looks fine.
-- best regards, Anthony On 4/28/2014 1:50 PM, Petr Pchelko wrote:
Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8041987 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8041987/ My recent fix with memory leak uncovered one more issue: in nativeSetDisplayMode the reference obtained outside of the block we use in the block. That's fine for Objective-C pointers, because they are auto-retained and autoreleased in this case. But for core foundation types we need to retain/release them manually. I've run all GraphicsDevice/GraphicsConfiguration/Fullscreen tests. I've also briefly skimmed the codebase for similar issues, but didn't find any obvious problems of such kind. Also I'm open-sourcing the tests which found the problem. With best regards. Petr.
