Hello, Petr,
the fix look good to me too.
Thanks,
Alexander.
On 05/07/2014 05:12 PM, Sergey Bylokhov wrote:
Hi, Petr.
The fix looks good.
On 07.05.2014 13:53, Petr Pchelko wrote:
Hello, Sergey.
Please see the updated webrev here:
http://cr.openjdk.java.net/~pchelko/9/8042219/webrev.01/
<http://cr.openjdk.java.net/%7Epchelko/9/8042219/webrev.01/>
1) if (fDropTarget != null)
1065 System.err.println("CComponent.addDropTarget(): current
drop target is non-null.");
Should we throw an exception instead or dispose the previous drop
target?
Fixed.
2) We can create/dispose DT on any thread?
Looks like yes. The caller (LWComponent) is doing all the necessary
synchronization.
3) {@inheritDoc} is obvious if no additional information is added.
Fixed.
With best regards. Petr.
On 30.04.2014, at 17:58, Sergey Bylokhov <[email protected]
<mailto:[email protected]>> wrote:
Hi, Petr.
A few comments:
1) if (fDropTarget != null)
1065 System.err.println("CComponent.addDropTarget(): current
drop target is non-null.");
Should we throw an exception instead or dispose the previous drop
target?
2) We can create/dispose DT on any thread?
3) {@inheritDoc} is obvious if no additional information is added.
On 4/30/14 5:33 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please review a simple cleanup fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8042219
The fix is available here:
http://cr.openjdk.java.net/~pchelko/9/8042219/webrev/
We should not reference macosx classes in lwawt package. I've also cleaned up
CDropTarget class a bit.
Thank you.
With best regards. Petr.
--
Best regards, Sergey.
--
Best regards, Sergey.
