Hello, Alexander. The fix looks good to me.
With best regards. Petr. On 12 мая 2014 г., at 19:44, Alexander Zvegintsev <[email protected]> wrote: > Hello AWT team, > > please review the fix > http://cr.openjdk.java.net/~azvegint/jdk/9/8041896/00/ > for the issue > https://bugs.openjdk.java.net/browse/JDK-8041896 > > This test failure is a regression of the JDK-7159566 fix. We trying to call > getLocationOnScreen() on a hidden popup. > We hide it if item count is 0 in AquaComboBoxPopup.show(). > However, native Cocoa apps doesn't show a popup if it is empty at all, this > fix do the same for java. > > With this fix RemoveAllShrinkTest test moved to open. > -- > Thanks, > > Alexander.
