Hello, Sergey. > Should we use getPopup() name, since it should be simple accessor? I thought about it. The HEAVYWEIGHT_POPUP constant is package-private, so if we use simple getPopup we would need a second method "getHeavyweightPopupType". So I was not quite sure which is better - use 2 methods or merge them in a single one. I can change it if you think 2 methods would be better.
With best regards. Petr. On 02 июня 2014 г., at 16:54, Sergey Bylokhov <[email protected]> wrote: > Hi, Petr. > Should we use getPopup() name, since it should be simple accessor? > > On 6/2/14 4:50 PM, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review a simple cleanup fix for the issue: >> https://bugs.openjdk.java.net/browse/JDK-8044516 >> The fix is available at: >> http://cr.openjdk.java.net/~pchelko/9/8044516/webrev/ >> >> No need to go through native to call a method. Accessor pattern works >> fine here, so we can avoid loading a native library. >> >> Thank you. >> With best regards. Petr. > > > -- > Best regards, Sergey.
