Hello, Yuri. > Let's do this way: if you think I really should do that, say so, > and I'll be back with a new version in a week. This was a suggestion and it's not critical. I'm OK with the fix either way.
With best regards. Petr. On 04 июня 2014 г., at 14:50, Yuri Nesterenko <[email protected]> wrote: > Hi Petr, > > that's one and the same question, in fact. > I'm commenting out the useless TestDialog setVisible(true) stuff. > Sure it would be better to trim that off completely. > It seems to me, however, that this well-known easy-to-ignore > garbage found in hundreds of other tests > doesn't hurt the test execution much. > We are trying to avoid refactoring whenever possible. > > Let's do this way: if you think I really should do that, say so, > and I'll be back with a new version in a week. > > Thank you Petr! > -yan > > On 06/04/2014 12:44 PM, Petr Pchelko wrote: >> Hello, Yuri. >> >> A couple of comments: >> 1. In HierarchyBoundsListenerMixingTest.java a couple of lines is left >> commented out. What's going on there? Same with MixingPanelsResizing.java >> 2. I see that tests open a TestDialog with some useless instructions and >> obvious info. What do you think about removing it completely together with >> the dialog code? >> >> With best regards. Petr. >> >> On 04 июня 2014 г., at 12:23, Yuri Nesterenko <[email protected]> >> wrote: >> >>> Weekly friendly reminder! >>> >>> Best regards, >>> -yan >>> >>> On 05/28/2014 07:06 PM, Yuri Nesterenko wrote: >>>> Hi, >>>> >>>> please review this change for RFE >>>> https://bugs.openjdk.java.net/browse/JDK-8044157 >>>> >>>> Webrev is in >>>> http://cr.openjdk.java.net/~yan/8044157/webrev.00 >>>> >>>> Thanks, >>>> -yan >>>> _______________ >>>> In this change, we remove an exact copy of one helper class >>>> and change some stray System.exits to RuntimeExceptions. >>>> >>>> Tested on 2 different Linux systems, on OS X and >>>> 2 Windows (7, 8.1). >>> >> >
