Hello, Jiri. Sorry for the delayed answer. From the code point of view you current change looks OK to me. It's an internal package and we can change the access modifier easily.
The more general question is what are you going to achieve by making this change? In JDK-9 we would have modules and you will not be able to use the sun.* packages at all, so this changeset is useless for JDK9. Do you want this to go to JDK8? In the original discussion there was a suggestion about providing a standard public interface for alternative plugins. This path looks more promising to me, because it will work in JDK9. Did any progress happen in that direction? Thank you. With best regards. Petr. On 19 июня 2014 г., at 18:35, Jiri Vanek <[email protected]> wrote: > On 06/16/2014 11:34 AM, Jiri Vanek wrote: > ping?? > >> ping? >> >> On 05/21/2014 05:02 PM, Jiri Vanek wrote: >>> >>> Hi! >>> >>> IcedTea-Web [1] have now patch [3] from [2] thread, to work pretty smooth >>> with all Icedteas, all >>> Openjdks and all Oracle javas. It even do work with IBM java. >>> However, we needed to include few lines of copypasted code [3] line >>> 274-283. Well it is not so much, >>> but is potentially dangerous. >>> >>> If this mini changeset - >>> http://jvanek.fedorapeople.org/oracle/jdk9/applet-minipatch/1/webrev/ may >>> go in, it would be awesome and will make icedtea-web true Openjdk plugin. >>> Do you think it is >>> possible? >>> >>> Just note - there already was a discussion about unnecessary complex >>> version of similar patch - [4] >>> thread. As result it forbid any touches to sun.applet package. However >>> current webrev do not add any >>> more visibility. It changes from private to package private. I hope it is >>> much more suitable >>> >>> I sent this message originally to jdk9-dev.. It/I was wrong I guess. Sorry >>> >>> Best regards, >>> J. >>> >>> [1] http://icedtea.classpath.org/wiki/IcedTea-Web >>> [2] >>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-May/027577.html >>> thread >>> [3] >>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140513/a47d6d04/allOpenJdk-0001.patch >>> >>> >>> [4] http://mail.openjdk.java.net/pipermail/jdk9-dev/2014-January/000320.html >>> >>> >> >
