The fix looks good to me.
Thanks,
Alexandr.
On 6/20/2014 10:26 AM, Dmitriy Ermashov wrote:
On 06/19/2014 06:39 PM, Petr Pchelko wrote:
Hello, Dmitriy.
It's impossible to review))
Impossible is nothing! (c))
I've briefly skimmed the classes and didn't see any problems with the
tests. Looks like these are pretty much the same)
These tests verify that GUI (AWT & Swing) components do not throw
unexpected exceptions in JVM headless mode and, on the other hand,
throw HeadlessException or IllegalStateException when it is documented.
No rocket science.
Did you check that these tests pass on all platforms?
Sure. I've verified tests on Windows 7, Ubuntu 14.04, OS X 10.9,
Solaris 11 and Ubuntu 10.04 (arm CPU).
Pass rate is 100% everywhere.
Thanks,
Dima
Thank you.
With best regards. Petr.
On 19 июня 2014 г., at 18:21, Dmitriy Ermashov
<dmitriy.ermas...@oracle.com> wrote:
Hi AWT team, Swing team,
Please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8047180
Webrev is here:
http://cr.openjdk.java.net/~dermashov/8047180/webrev.00/
It is one more batch of functional tests moving to OpenJDK repo.
This batch covers just one functional test
AWT_Headless/Automated/Headless_BAT.
The changeset is pretty large, but the initial test consists of
~220'000 lines of java code split on many files.
Thanks for your understanding!
-dima
