Hello, Anthony. > Note that there's also AWT API to set a menubar, and it seems (I haven't > investigated deeply) that the LWAWT implementation uses the system menu bar > unconditionally in this case. I believe we can assume that AWT API isn't used > widely and we can leave it as it is. But it's worth noting this in the bug > comments. Yes, I've tested this and you are right. I agree that we shouldn't touch this, because it would affect existing AWT applications that could've used this API without the useScreenMenuBar system property. I'll add a not about this to the bug comments.
With best regards. Petr. On 02 июля 2014 г., at 18:37, Anthony Petrov <[email protected]> wrote: > Hi Petr, > > The fix looks fine to me. > > Note that there's also AWT API to set a menubar, and it seems (I haven't > investigated deeply) that the LWAWT implementation uses the system menu bar > unconditionally in this case. I believe we can assume that AWT API isn't used > widely and we can leave it as it is. But it's worth noting this in the bug > comments. > > -- > best regards, > Anthony > > On 7/2/2014 6:25 PM, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review the fix for the issue: >> https://bugs.openjdk.java.net/browse/JDK-8048549 >> The fix is available at: >> http://cr.openjdk.java.net/~pchelko/9/8048549/webrev/ >> >> We need to disable the screenMenuBar if AWT is embedded into FX. Only the >> top-level UI toolkit should work with the global menu bar. >> We are already doing the same thing in FX. I've also added some cleanup into >> the fix. No test provided because we do not have tests for >> embedded mode. >> >> With best regards. Petr. >>
