Looks good to me. With best regards. Petr.
> On Jul 3, 2014, at 6:49 PM, Dmitriy Ermashov <dmitriy.ermas...@oracle.com> > wrote: > > Hi, > I've updated the webrev, so could you please review it? > http://cr.openjdk.java.net/~dermashov/8048246/webrev.02/ > > Last changes: > 1. Clipboard folder moved to datatransfer folder. > 2. Removed private fields/methods call from AddFlavorClipboard test > 3. Test GetContentsInterruptedTest.java is a replacement for corresponding > closed test > > Thanks, > Dima > > On 07/03/2014 02:30 PM, Petr Pchelko wrote: >> Hello, Dmitriy. >> >> As we do not have a Clipboard folder yet, could you please put Clipboard >> tests under java/awt/datatransfer/Clipboard so that all data transfer tests >> are in the same folder. >> AddFlavorTest:80 - here the test is using the private method via reflection. >> Please remove this part of the test (or the whole test if it looses it’s >> meaning without it). I will make big changes in the implementation soon, so >> this test will start to fail. >> >> I didn’t analyze every assertion, but as long as the tests pass on all >> platforms I’m OK with the rest of the fix. >> >> With best regards. Petr. >> >> >>> On Jul 3, 2014, at 1:51 PM, Dmitriy Ermashov <dmitriy.ermas...@oracle.com> >>> wrote: >>> >>> Hi all, >>> >>> Please review the updated version of tests to be colocated. >>> http://cr.openjdk.java.net/~dermashov/8048246/webrev.01/ >>> http://cr.openjdk.java.net/~dermashov/8048246/webrev.diff.01/ >>> >>> Last changes: >>> 1. Removed 1 test from closed part. New GetContentsInterruptedTest.java is >>> an up-to-date copy of it. >>> >>> Thanks, >>> Dima >>> >>> On 07/01/2014 03:44 PM, Dmitriy Ermashov wrote: >>>> Hi, >>>> >>>> Please review a new batch of functional AWT tests. Clipboard tests this >>>> time. >>>> http://cr.openjdk.java.net/~dermashov/8048246/webrev.00/ >>>> >>>> Corresponding bug: >>>> https://bugs.openjdk.java.net/browse/JDK-8048246 >>>> >>>> The changeset is pretty large, but, as always, it is several times smaller >>>> than original test suite. >>>> Tests were verified on the following platforms: >>>> Windows 7 x64 >>>> Ubuntu 14.04 x64 >>>> OS X 10.9.4 x64 >>>> Solaris 11 x64 >>>> Ubuntu 10.04 arm >>>> >
