Hello, Sergey. The fix looks good to me. I assume that you will file a separate bug for returning parfait problems.
With best regards. Petr. On 10 июля 2014 г., at 18:11, Sergey Bylokhov <[email protected]> wrote: > Hello. > Please review the fix for jdk 9. > The bug reproduced on xp only, regression of JDK-8035739 > Description: > void * is 4 bytes > jboolean is 1 byte. > > Before the fix we cast to jboolean after the fix not[1]. On XP part of the > return value is not zeroed. So false became true. > All places where we use JNI_IS_TRUE and SysCall were reverted. > > [1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5d22ffb8b826 > Bug: https://bugs.openjdk.java.net/browse/JDK-8049583 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8049583/webrev.00 > -- > Best regards, Sergey.
