Thanks!
On 21.07.2014 12:56, Petr Pchelko wrote:
Hello, Alexander.
Thank you for the update. The new version looks good to me.
With best regards. Petr.
On 21 июля 2014 г., at 12:52, alexander stepanov
<alexander.v.stepa...@oracle.com> wrote:
Hello Petr,
I didn't observe the remaining windows when the tests are running with jtreg
and failing (jtreg closes them).
But anyway, the version with 'finally' is better, thanks. Please see the webrev
updated:
http://cr.openjdk.java.net/~avstepan/8049617/webrev.01/
Regards,
Alexander
On 21.07.2014 11:01, Petr Pchelko wrote:
Hello, Alexander.
In doTest you are doing closeAll in the end. But if the test is failed and any
assert throws an exception, closeAll will not be called and a frame could be
left on the screen. I think it's better to call closeAll from a finally block.
With best regards. Petr.
On 18 июля 2014 г., at 16:59, alexander stepanov
<alexander.v.stepa...@oracle.com> wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8049617
webrev:
http://cr.openjdk.java.net/~avstepan/8049617/
This is the next portion of functional AWT tests prepared for migration to
OpenJDK repository.
The tests were checked on Ubuntu 14.04 Linux, Solaris 11, Mac OS X 10.8.5 and
Windows 7.
Thanks,
Alexander
