> On Jul 21, 2014, at 7:31 PM, Sergey Bylokhov <[email protected]> > wrote: > > On 7/21/14 7:22 PM, Petr Pchelko wrote: >>>> What do you think about filing new CRs for private final methods and >>>> static final methods? >>> Actually I have nothing against private/static final methods. Some times I >>> used them >> private final is useless because you can’t override it anyway. It’s arguable >> as we can possibly >> change the method to protected and forget to add final, > but subclasses can create the method with the same name , this sometime is > not obvious for readers. >> but static methods cannot be overridden >> at all, so final in this case is completely useless and it only annoys as >> IDEA highlights these issues. > Same for static, http://youtrack.jetbrains.com/issue/IDEA-92076 > Usually I mark all my static method as final. Ok, I agree. Idea tricked me a bit) Anyway, it’s not related directly to the current review.
With best regards. Petr. > On Jul 21, 2014, at 7:31 PM, Sergey Bylokhov <[email protected]> > wrote: > > On 7/21/14 7:22 PM, Petr Pchelko wrote: >>>> What do you think about filing new CRs for private final methods and >>>> static final methods? >>> Actually I have nothing against private/static final methods. Some times I >>> used them >> private final is useless because you can’t override it anyway. It’s arguable >> as we can possibly >> change the method to protected and forget to add final, > but subclasses can create the method with the same name , this sometime is > not obvious for readers. >> but static methods cannot be overridden >> at all, so final in this case is completely useless and it only annoys as >> IDEA highlights these issues. > Same for static, http://youtrack.jetbrains.com/issue/IDEA-92076 > Usually I mark all my static method as final. >> >> With best regards. Petr. >> >> >>> On Jul 21, 2014, at 7:12 PM, Sergey Bylokhov <[email protected]> >>> wrote: >>> >>> On 7/21/14 6:53 PM, Petr Pchelko wrote: >>>> Hello, Sergey. >>>> >>>> The fix looks good. >>>> >>>> What do you think about filing new CRs for private final methods and >>>> static final methods? >>> Actually I have nothing against private/static final methods. Some times I >>> used them >>>> >>>> With best regards. Petr. >>>> >>>>> On Jul 21, 2014, at 5:35 PM, Sergey Bylokhov <[email protected]> >>>>> wrote: >>>>> >>>>> Hello. >>>>> Please review a small fix of warnings from another one tool: >>>>> I fix all related issues in the client code. >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6521783 >>>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/6521783/webrev.00 >>>>> >>>>> -- >>>>> Best regards, Sergey. >>>>> >>> >>> >>> -- >>> Best regards, Sergey. >> > > > -- > Best regards, Sergey.
