Hi Alexander,
I don't see any immediate problems with the changes and generally the
fix looks good to me. However, I suppose that on some rare window
managers this might not work as expected. We should understand the risk
and be ready to fix problems if any regressions are reported.
Also note that there are non-, single-, and double- (and possibly even
multi-) re-parenting window managers. See XWM.java for details. Have you
tested this code with at least one WM of each of these categories to
ensure we don't break things?
--
best regards,
Anthony
On 8/12/2014 11:36 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8051617/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8051617
Our logic for detecting top level window may fail on some window managers.
This fix passes this window directly.
