Thanks, Sergey I've push the change. Cheers - Jonathan
On Wed, Sep 24, 2014 at 11:46 PM, Sergey Bylokhov < [email protected]> wrote: > Note that your fix should be pushed to: > http://hg.openjdk.java.net/jdk9/client/jdk/ > > On 24.09.2014 18:33, Jonathan Lu wrote: > > Hi Sergey, > > Thanks for review! here's the updated webrev > http://cr.openjdk.java.net/~luchsh/JDK-8058930.2/ > > > On Wed, Sep 24, 2014 at 6:39 PM, Sergey Bylokhov < > [email protected]> wrote: > >> Hi, Jonathan. >> The fix looks fine, but a few notes about the test: >> - Is it possible to make this test applicable to all platforms? >> > > I'm making it for non-Windows platforms in v2 patch, since the code > change is a *nix only expression. > > > >> - "Copyright (c) 2014 Oracle" should be "Copyright (c) 2014, Oracle " >> > > My bad, have fixed that in v2 patch. > > >> >> On 24.09.2014 8:54, Jonathan Lu wrote: >> >>> Hello, >>> >>> Could you please review following fix: >>> >>> Webrev: http://cr.openjdk.java.net/~luchsh/JDK-8058930/ < >>> http://cr.openjdk.java.net/%7Eluchsh/JDK-8058930/> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058930 >>> >>> It is a simple fix to make GraphicsEnvironment.getHeadleassProperty() to >>> return the correct value on AIX. >>> >>> Many thanks >>> - Jonathan >>> >> >> >> -- >> Best regards, Sergey. >> >> > Thanks > - Jonathan > > > > -- > Best regards, Sergey. > >
