Hi, Mikhail.
The fix looks good.
On 02.10.2014 17:18, mikhail cherkasov wrote:
oh sorry about this, I forgot to remove this code, it was used for
debug purposes only.
there is correct version:
http://cr.openjdk.java.net/~mcherkas/8038919/webrev.03/src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.udiff.html
On 10/2/2014 5:02 PM, Sergey Bylokhov wrote:
Hi, Mikhail.
Why this code is needed in CPlatformWindow.java?
"Container parent = getPeer().getTarget().getParent()" note that
getPeer() can return null.
On 01.10.2014 15:19, mikhail cherkasov wrote:
Hi there,
it's just friendly reminder about this review request.
Thanks,
Mikhail.
On 9/25/2014 7:49 PM, mikhail cherkasov wrote:
Hi Sergey,
Please review updated version:
http://cr.openjdk.java.net/~mcherkas/8038919/webrev.02/
Thanks,
Mikhail.
On 9/23/2014 7:08 PM, Sergey Bylokhov wrote:
Hi, Mikhail.
I guess it will be better to move this new method to the Toolkit
class, where isApplicationActive is defined, because it is
unrelated to CPlatformWindow.
On 19.09.2014 19:02, mikhail cherkasov wrote:
Hi there!
Just friendly reminder about this review request.
Thanks,
Mikhail.
On 9/16/2014 3:39 PM, mikhail cherkasov wrote:
Hello all,
please review the fix
http://cr.openjdk.java.net/~mcherkas/8038919/webrev.01/
bug: https://bugs.openjdk.java.net/browse/JDK-8038919
The problem appears if we trying to call toFront when embedded
window is active in browser, this
call is ignored, because for macosx the browser process is
active and it ignores
[nsWindow orderFront:nsWindow] call to java process windows.
To fix this issue I use [NSApp activateIgnoringOtherApps:YES];
before [nsWindow orderFront:nsWindow]
if an embedded frame is active window.
Thanks,
Mikhail.
--
Best regards, Sergey.
