Yes, please, wait a second review.
On 10.11.2014 17:04, Denis S. Fokin wrote:
Hi Sergey,
Thank you for the review. Do I need another reviewer to push?
Thank you,
Denis.
On 10 Nov 2014, at 15:12, Sergey Bylokhov <[email protected]
<mailto:[email protected]>> wrote:
Hi, Denis.
The fix looks fine.
Updated webrev for the current jdk layout:
http://cr.openjdk.java.net/~serb/denis/8057788/webrev.00
On 08.09.2014 16:12, Denis Fokin wrote:
Hi AWT team,
I know a lot of people who miss “pinch to zoom” feature in Java.
It is implemented for jdk 6 but the functionality does not work in
jdk 7 and latter releases.
Gesture related callbacks were mistakenly placed in NSWindowDelegate
instead of NSWindow.
Please take a look at this simple move refactoring.
http://web-dot.ru/openjdk/pinch-to-zoom-fix/webrev.00/index.html
Actually, I would eliminate the macros
AWT_NS_WINDOW_IMPLEMENTATION. It is difficult to debug. Looks like
it was added to avoid code duplication but if AWTWindow_Normal and
AWTWindow_Panel implementations are the same we should reuse the
same class.
I have submitted a bug about the issue but it is not visible yet.
Thank you,
Denis.
--
Best regards, Sergey.
--
Best regards, Sergey.
