+1
Mandy
On 4/8/2015 11:00 AM, Phil Race wrote:
That looks good to me.
-phil.
On 4/8/2015 10:55 AM, Pete Brunet wrote:
How's this?
http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.03
On 4/8/15 12:47 PM, Mandy Chung wrote:
I agree with Phil's suggestion and file a bug to follow up the javadoc
build issue.
You can verify the result from make docs that there is no javadoc
generated for this package on windows build.
Mandy
On 4/8/2015 10:29 AM, Phil Race wrote:
Isn't it sufficient to comment out this one line ?
1215 ALL_OTHER_TARGETS += jaccessdocs
.. and add a comment as to why ?
-phil.
On 04/08/2015 10:25 AM, Pete Brunet wrote:
Here is an updated patch.
http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.02/
It simply removes the com.sun.java.accessibility.util part of the
javadoc generation.
How to better deal with the javadoc generation can be left to later.
Please let me know if this patch meets with your approval.
I have started a local Win build and will start JPRT builds on Linux,
Windows, Solaris, and Mac shortly.
Thanks,
Pete
On 4/8/15 12:51 AM, Pete Brunet wrote:
Please review/approve the following patch.
http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.01/
The recent push for JDK-8076182 caused a build break, i.e. a
problem for
the creation of the Javadoc in the environment used by the nightly
build. This was because a newly opened package
com.sun.java.accessibility.util was mistakenly located in a windows
directory. This patch moves the package's files from
jdk/src/windows/classes to jdk/src/share/classes and this should
resolve
the build break for the jdk8u-dev nightly.
JPRT builds run OK on solaris, mac, and linux. As of this
writing the
Win jobs haven't started yet but the 64 bit build completed OK on my
local machine.
This patch also had to include the fix for JDK-8051297 "Remove
com.sun.java.accessibility.util.java.awt.ChoiceTranslator". That
file
is dead code and its existence in jdk/src/share/classes causes a
compilation failure, access of a non-existent enum, the reason the
file
was planned to be removed.
Thanks, Pete
