----- Original Message ----- > I think you meant the subject to be "RFR: 8081315 ..." >
Ah yes, I moved the 8077982 in front of the colon when it's actually part of the bug description i.e. RFR: 8081315: 8077982 giflib upgrade :( > if (DGifCloseFile(gif, NULL) == GIF_ERROR) > return 0; > > I suppose we probably ought to be checking the (new) error returns > although I am not sure what impact a failure on this particular > call would have if we already had read the data. I'm not sure about this myself; it's much like the IOException that can be thrown from closing a Java stream. As far as I can see from [0], it would throw an error if it fails in reading the GIF terminating block or deallocating used memory. > > But could you write this as > > if (DGifCloseFile(gif, NULL) == GIF_ERROR){ > return 0; > } > Done: http://cr.openjdk.java.net/~andrew/8081315/webrev.02/ > ? > > > -phil. > > [0] http://giflib.sourceforge.net/gif_lib.html -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07