On 26.07.15 1:20, Michael Hall wrote:
On Jul 9, 2015, at 5:49 AM, Sergey Bylokhov
<sergey.bylok...@oracle.com <mailto:sergey.bylok...@oracle.com>> wrote:
Hello.
Please review the fix for jdk9.
This is the last issue, which prevents us to build the jdk on osx
using the latest clang w/o --disable-warnings-as-errors.
I may not be understanding this correctly. But, I just did a build on
OS X and after running into the error in the subject I changed to
-disable-warnings-as-errors and seemed to get more warnings following
this one. Including ones for awt. Like…
/Users/mjh/jdk9/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/PrinterView.m:207:21:
warning: implicit conversion from enumeration
type 'NSPaperOrientation' (aka 'enum NSPaperOrientation') to different
enumeration type 'NSPrintingOrientation' (aka 'enum
NSPrintingOrientation') [-Wenum-conversion]
[[[NSPrintOperation currentOperation] printInfo]
orientation];
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mjh/jdk9/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/PrinterView.m:214:60:
warning: implicit conversion from enumeration type
'enum NSPrintingOrientation' to different enumeration type
'NSPaperOrientation' (aka 'enum NSPaperOrientation') [-Wenum-conversion]
setOrientation:NSPortraitOrientation];
^~~~~~~~~~~~~~~~~~~~~
/Users/mjh/jdk9/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/PrinterView.m:222:60:
warning: implicit conversion from enumeration type
'enum NSPrintingOrientation' to different enumeration type
'NSPaperOrientation' (aka 'enum NSPaperOrientation') [-Wenum-conversion]
setOrientation:NSLandscapeOrientation];
^~~~~~~~~~~~~~~~~~~~~~
3 warnings generated.
Would these warnings not end up as errors that would stop the build?
No, because lwawt library does not set "warning as error" option for now.
Michael Hall
--
Best regards, Sergey.
