Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

[Semyon Sadetsky]

Looks good.

--Semyon

On 9/22/2015 7:42 AM, Renjith Alexander wrote:

Hi All,

I need one more approval for this item. Could somebody please review it?

Regards,

Renjith.

*From:*Renjith Alexander
*Sent:* Tuesday, September 15, 2015 2:33 PM
*To:* Andrei Eremeev; awt-dev@openjdk.java.net

*Subject:* Re: <AWT Dev> Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

Hi Andrei,

Please see the updated version: http://cr.openjdk.java.net/~pchopra/8132380/webrev.01/ <http://cr.openjdk.java.net/%7Epchopra/8132380/webrev.01/>

Regards,

Renjith.

*From:*Andrei Eremeev
*Sent:* Friday, September 11, 2015 6:34 PM

*To:* Renjith Alexander; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* Re: <AWT Dev> Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

Hi Renjith,

Swing components should be created on the EDT to avoid concurrency problems.

So rollback the 55, 56, 61 and 62 lines.

Look at: https://docs.oracle.com/javase/tutorial/uiswing/concurrency/index.html

Andrei

On 11.09.2015 13:16, Renjith Alexander wrote:

    Hi all,

    Please review the fix for the bug:  JDK-8132380: Do not create LaF
    instance in javax/swing/plaf/windows/6921687/bug6921687.java

    BUG ID - *https://bugs.openjdk.java.net/browse/JDK-8132380 *

    The webrev is:
    http://cr.openjdk.java.net/~pchopra/8132380/webrev.00/
    <http://cr.openjdk.java.net/%7Epchopra/8132380/webrev.00/>

--

    Regards,

    Renjith Alexander