Hi Avik,

Did you try to change the locale? Did button get the localized text then?
Why do you use trailing white-spaces for the key?
The second argument of NSLocalizedString should be a comment. Perhaps, it'd be better to write a key description there instead of repeating the key.

--Semyon

On 11/23/2015 9:34 AM, Avik Niyogi wrote:
Hi All,

Kindly review the fix for JDK9.
*Bug*:
https://bugs.openjdk.java.net/browse/JDK-8019280

*Webrev*:
http://cr.openjdk.java.net/~aniyogi/8019280/webrev.00/ <http://cr.openjdk.java.net/%7Eaniyogi/8019280/webrev.00/>

*Issue*: The OpenJDK implementation of CFileDialog for mac is inconsistent with how Apple's implementation would show the selection button when the dialog was set to choose directories. Expected correct caption on the selection button should be " Choose " , not " Open " according to Mac OSX UI guidelines.

*Cause*: Incorrect implementation within CFileDialog.m

*Fix*:Added logic to setPrompt when opening a directory selection File Dialog

With Regards,
Avik Niyogi

Reply via email to