Hi Semyon, Updated webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.03/
Justification: Yes, we can change the number of times the mouse moves up and down and this should not break the original scenario because the up and down movement is being performed so that there is enough time for the text selection to complete and also for the scenario where the selection may not happen all at once till the end of the textArea, but in parts, I changed this from 26 times to 5 times (tremble < 10) and the selection is still able to complete properly on all the tested machines (Windows/Mac/Solaris). Best Regards, Vikrant -----Original Message----- From: Semyon Sadetsky Sent: Wednesday, March 09, 2016 1:35 PM To: Vikrant Agarwal; awt-dev@openjdk.java.net; Alexander Stepanov Subject: Re: <AWT Dev> Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html Hi Vikrant, What does the test do 95% of its execution time the is mouse move ~ 10px up and down. It doesn't look sensible to me. Is it possible to make this phase of the test shorter and decrease number of such movements? Of cause, if this won't break the original scenario. --Semyon On 3/8/2016 4:53 PM, Vikrant Agarwal wrote: > Hi All, > > Gentle Reminder, I need one more approval to push this fix. > > Best Regards, > Vikrant > > -----Original Message----- > From: Vikrant Agarwal > Sent: Friday, March 04, 2016 11:01 AM > To: Semyon Sadetsky; Sergey Bylokhov; awt-dev@openjdk.java.net; > Alexander Scherbatiy > Subject: Re: <AWT Dev> Review request for 6734341 : REGTEST fails: > SelectionAutoscrollTest.html > > Hi Semyon, > > Although the execution time of the previous version was shorter, but it was > also failing many times, the extra execution time got introduced after > repacing mouseMove() from java.awt.Robot with mouseMove() from > test.java.awt.regtesthelpers.Util , this performes the mouse movement a > little slower than the previous one, but also makes the test more stable, as > the new version is passing on all the tested machines. > > Best Regards, > Vikrant > > -----Original Message----- > From: Semyon Sadetsky > Sent: Thursday, March 03, 2016 5:53 PM > To: Vikrant Agarwal; Sergey Bylokhov; awt-dev@openjdk.java.net; > Alexander Scherbatiy > Subject: Re: Review request for 6734341 : REGTEST fails: > SelectionAutoscrollTest.html > > Hi, Vikrant, > > I ran the new test version on Windows. It's execution time is about 20 > seconds while the previous version was instant. > Is that expected? > > --Semyon > > > > On 2/26/2016 3:53 PM, Vikrant Agarwal wrote: >> Hi Sergey, >> >> I have updated the test to a standalone test. >> >> Updated Webrev: >> http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.02/ >> >> Bug: JDK-6734341 : REGTEST fails: SelectionAutoscrollTest.html >> >> Best Regards, >> Vikrant >> >> -----Original Message----- >> From: Sergey Bylokhov >> Sent: Thursday, February 25, 2016 2:03 AM >> To: Vikrant Agarwal; awt-dev@openjdk.java.net; Alexander Scherbatiy; >> Semyon Sadetsky >> Subject: Re: Review request for 6734341 : REGTEST fails: >> SelectionAutoscrollTest.html >> >> Hi, Vikrant. >> The @bug tag should be updated in the html file, because it have a @test >> tag. But I suggest to remove the html file and change >> SelectionAutoscrollTest.java to a standalone test(instead of Applet). >> >> On 24.02.16 11:25, Vikrant Agarwal wrote: >>> Hi All, >>> >>> Please review the fix for JDK9. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-6734341 >>> >>> Webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.00/ >>> >>> Issue: java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest >>> test was always failing for mac and intermittently failing for other >>> platforms. >>> >>> Fix: using mouseMove() from test.java.awt.regtesthelpers.Util insted >>> of >>> mouseMove() from java.awt.Robot makes the test more stable and the >>> test passes on all the tested machines including mac. >>> >>> Best Regards, >>> >>> Vikrant >>> >> -- >> Best regards, Sergey.
