Hello Sergey,
> because setImageAutoSize is false by default.
Could you please review the fix:
http://cr.openjdk.java.net/~avstepan/8150643/fix.00/
If it is suitable, I'll push it after a test bug creation.
Thanks,
Alexander
On 2/26/2016 8:34 PM, Sergey Bylokhov wrote:
Just one additional note: When you created a MRI you set a nok image
as a base image, which means that the size of the MRI will consider
wrong(small). And this contradicts the description of the test:
"Please check if both of them have correct size", because
setImageAutoSize is false by default. But it seems we have a bug
because setImageAutoSize(true) does not help. I'll update the test in
JDK-8150176.
On 26.02.16 19:09, Alexander Stepanov wrote:
Thanks! (will remove "for a few seconds").
Regards,
Alexander
On 2/26/2016 6:25 PM, Sergey Bylokhov wrote:
Looks fine.
Note that the text "Two tray icons will appear for a few seconds
" should be updated also.
On 26.02.16 18:04, Alexander Stepanov wrote:
> Is it possible to clear the tray when the test ended?
Yes, we can use the Applet's stop() method, please see
http://cr.openjdk.java.net/~avstepan/8150643/webrev.01/
Thanks,
Alexander
On 2/26/2016 4:47 PM, Sergey Bylokhov wrote:
I think it is not a good idea to block the EDT, or to expect that the
user will be able to find icon in a 7 seconds, especially if he run
the test for the firts time. Is it possible to clear the tray when
the
test ended?
On 26.02.16 16:39, Alexander Stepanov wrote:
Hello Sergey,
This is a time interval for the user to examine the icons (which
could,
e.g., go to the tray pool). So my feeling is that it is a more or
less
suitable interval, but it could be shortened for a couple of
seconds, of
course.
Thanks,
Alexander
On 2/26/2016 4:31 PM, Sergey Bylokhov wrote:
Is it really necessary to block the EDT for 7 seconds?
On 25.02.16 18:22, Alexander Stepanov wrote:
(sorry, misprint, <AWT Dev> [9], not [8]. the same for RFR
8150258)
On 2/25/2016 5:50 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150643/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150643 ?
Just a single test added (still failing).
Thanks,
Alexander
