Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

[Semyon Sadetsky]

Looks good.

--Semyon

On 3/13/2016 12:17 AM, Ambarish Rapte wrote:

Hi All,

I have updated the webrev with a change in Text Area code.

There was an issue with webrev.01 that, In Text Area last line does not get selected while selecting vertically downards.

Please review the updated webrev.02

http://cr.openjdk.java.net/~arapte/8149636/webrev.02/ <http://cr.openjdk.java.net/%7Earapte/8149636/webrev.02/>

Thanks,

Ambarish

*From:*Ambarish Rapte
*Sent:* Friday, March 11, 2016 7:56 PM

*To:* Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net *Subject:* RE: <AWT Dev> Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

Hi,

Gentle reminder for review…

Thanks,

Ambarish

*From:*Ambarish Rapte
*Sent:* Tuesday, March 08, 2016 9:19 PM

*To:* Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* Re: <AWT Dev> Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

Hi Semyon,

Please review the webrev.01, updated as per review comments

http://cr.openjdk.java.net/~arapte/8149636/webrev.01/ <http://cr.openjdk.java.net/%7Earapte/8149636/webrev.01/>

Changes:

1.Added similar changes for TextArea.

2.Added automatic test to test over scroll.

3.Text Field Flicker test is manual, as cannot be automated.

Thanks,

Ambarish

*From:*Semyon Sadetsky
*Sent:* Friday, March 04, 2016 11:57 AM

*To:* Ambarish Rapte; Prasanta Sadhukhan; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* Re: <AWT Dev> Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

Hi Ambarish,

the first point is not valid. Please, ignore it.

--Semyon

On 3/1/2016 11:14 AM, Semyon Sadetsky wrote:

    Hi Ambarish,

    - The over scroll remains after the proposed fix.

    - The bug is a regression of 7092551 and should be labeled
    correspondingly.

    - An automatic test may and should be provided with the fix.

    - The same issue existing in the TextArea should be fixed as well.

    --Semyon

    On 2/11/2016 12:23 PM, Ambarish Rapte wrote:

        Hi,

                        Please review the fix for JDK9,

                        Bug:
        https://bugs.openjdk.java.net/browse/JDK-8149636

                        Webrev:
        http://cr.openjdk.java.net/~arapte/8149636/webrev.00/
        <http://cr.openjdk.java.net/%7Earapte/8149636/webrev.00/>

        Issue:

                        While scrolling with selection, when mouse is
        dragged outside the bounds of TextField,

        a.TextField flickering is observed

        b.TextField over scrolls on right. Text gets hidden on left
        side even when no scroll is needed.

        Cause:

        a.Flicker –
        For simulating scroll, scroll bar information is used.
        To get correct scroll info, scroll bar should be visible.
        Showing and hiding of scroll bar causes the flickering.

        b.Over Scroll –

        The scrolling logic scrolled the textField in units of half
        the si.nPage. i.e. (si.inPage / 2) maximum till si.nMax,
        Which causes the over scroll.

        Fix:

                        ES_AUTOHSCROLL set for the TextField enables
        the automatic horizontal scrolling, so we need not add code
        for scrolling.

                        Only selection should be updated as the mouse
        moves.

                        Hence removed the code to related to
        SendMessage( WM_HSCROLL,…)  i.e. scrolling

        Verification:

                        Manually Verified that textField editing /
        selection / copy / paste works fine.

                        No Jtreg, JCK tests related to TextField fail
        due to this change.

                        Updated an existing test
        *ScrollSelectionTest.java *to test the scenarios mentioned in
        the bug.

        Thanks,

        Ambarish