213 * by the underlying operating system and/or window manager). Note that on 214 * platforms where dynamic layout during resizing is not supported (or is 215 * always supported) by the OS/WM, ({@code isDynamicLayoutSet()}) property
 216      * has no effect.

Not sure that it is correct to talk about "effect" of a method that is not expected to change anything . Usually it is told about effect of a change but the getter method is not the case.
I might be wrong and this may have valid meaning in English.

50         t.setDynamicLayout(true);
  51         if(!t.isDynamicLayoutSet()){
52 throw new RuntimeException("'true' expected but 'false' returned");
  53         }

The test fails in the reviewed scenario when setDynamicLayout(true) has no effect .



On 9/23/2015 10:01 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.

We have 3 methods and one desktop property to support
behavior during resize of the window:
- Property "awt.dynamicLayoutSupported" describe support of this feature by the current OS. - Method isDynamicLayoutActive() describe: is this feature currently active or not. - isDynamicLayoutSet/setDynamicLayout is a possibility to change the current state of the feature.

The problem is that the method isDynamicLayoutActive() has no description what happens if the OS supports(or nonsupports) the feature, but the change of the state is not supported, which means that the value, which was set in setDynamicLayout() is ignored. Moreover this documentation states that isDynamicLayoutSet() is never ignored.

Documentation is updated using the same description as in setDynamicLayout(); The existed test is updated to cover this situation.

This bug causes a jck failure see JCK-7301760.
ccc request will be created after the technical review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8027324
Webrev can be found at: http://cr.openjdk.java.net/~serb/8027324/webrev.00


Reply via email to