Re: Review request for 8033936: java.awt.List events are not sent properly to handleEvent or ItemListener

[Ambarish Rapte]

Hi Prasanta,

                Thanks for the review.

                The test class is extended from Frame, hence call to dispose 
works.

 

                PerformTest is called twice for the below two scenarios,

1.       To test Event received by List's parent Frame's handleEvent()   -> 
Called testHandleEvent()

2.       To test ItemEvent received by ItemListener registered by the List.   
-> Called testItemListener()

 

                

Thanks,

Ambarish

 

From: prasanta sadhukhan 
Sent: Tuesday, March 22, 2016 2:11 PM
To: Ambarish Rapte; Semyon Sadetsky; awt-dev@openjdk.java.net
Subject: Re: Review request for 8033936: java.awt.List events are not sent 
properly to handleEvent or ItemListener

 

FIx looks ok to me.
But in testcase, there is no dispose() method but you are still calling 
dispose(). Also, why there is a need to call performTest() twice?

Regards
Prasanta

On 3/18/2016 2:04 PM, Ambarish Rapte wrote:

Hi,

                Please review the fix for JDK9,

                Bug: https://bugs.openjdk.java.net/browse/JDK-8033936

Webrev: http://cr.openjdk.java.net/~arapte/8033936/webrev.00/

 

 

Issue:

                In a multi select list, when multiple items are selected and 
then deselected,

                the ItemEvent received does not have correct information about 
the deselected item.

 

Cause:

                In a multi select List, while deselecting an item the focus 
caret is not updated to recently clicked item.

                But the focus caret remains at the last item clicked while 
selecting the items.

 

Fix:

                Update the caret index while deselecting the items to recently 
clicked item.

 

Verification:

                Verified the regression and JCK tests after the fix - there are 
no failures due to this change.

                Verified the newly included test on Windows, Ubuntu & Mac.

 

 

 

 

Regards,

Ambarish