Re: Review request for 8151998 VS2010 ThemeReader.cpp(758) : error C3861: 'round': identifier not found

[Semyon Sadetsky]

+1

--Semyon

On 3/23/2016 5:10 PM, Alexander Scherbatiy wrote:

Hello,

Could you review the updated fix:
  http://cr.openjdk.java.net/~alexsch/8151998/webrev.01

The _MSC_VER predefined macros is used for the Visual Studio version detection.

 Thanks,
 Alexandr.

On 3/16/2016 4:27 PM, Alexander Scherbatiy wrote:

Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8151998
  webrev: http://cr.openjdk.java.net/~alexsch/8151998/webrev.00

The fix uses the "ROUND_TO_INT(num) ((int) floor((num) + 0.5))" instead round function which is not compiled by VS2010.

Thanks,
Alexandr.