Hi Ramesh
The fix looks good.
However, could you please check if the test can be run without the 6000 delay.
Please arrange the lines to 80 char length.
Please remove the System.out.println() calls.
Regards,
Ambarish
From: Ramesh Gangadhar
Sent: Tuesday, April 19, 2016 11:09 AM
To: [email protected]
Subject: Re: <AWT Dev> Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hello All,
This is a gentle remainder for review.
Best Regards,
Ramesh BG
From: Ramesh Gangadhar
Sent: Tuesday, April 12, 2016 14:41
To: HYPERLINK "mailto:[email protected]"[email protected]
Subject: Re: <AWT Dev> Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hello,
Please review bug fix for 8027154
bug: https://bugs.openjdk.java.net/browse/JDK-8027154
Webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.02/
Issue:
mouseMoved(MouseEvent) recieves sometimes position as [29,29] and sometimes as
[30,30] from AWT native code
What modifications Done?
Since this testcase is mainly focused on checking mouse position instead of two
Robot.mouseMove(149,149) and Robot.mouseMove(150,150) method calls it is
reduced to only one call of Robot.mouseMove(150,150) and also removed creation
of OuterFrame when mouseMoved on InnerFrame.
Verification:
Code Tested on Windows and oracle linux for verification.
Best Regards,
Ramesh BG
From: Ambarish Rapte
Sent: Monday, April 04, 2016 4:56 PM
To: Ramesh Gangadhar; HYPERLINK
"mailto:[email protected]"[email protected]
Subject: RE: <AWT Dev> Review Request for bug JDK-8027154
Hi Ramesh,
Below are few comments,
General comments :
1. Please provide description about bug cause & how this change fixes the
bug, with the review email.
Also update the bug on JBS with similar analysis.
2. Subject line for review email should in format, "Review Request For
BUG_ID : BUG summary line"
3. Remove wild card import statements, @author tag & System.out.println
lines.
Comments Specific to the test:
4. Passing null to Util.waitForIdle() creates a new robot object at each
call, instead please pass the created robot object.
5. The delay on line number 86 can be removed, Util.WaitForIdle() should
be sufficient for synchronization.
Thanks,
Ambarish
From: Ramesh Gangadhar
Sent: Friday, April 01, 2016 12:28 PM
To: HYPERLINK "mailto:[email protected]"[email protected]
Subject: <AWT Dev> Review Request for bug JDK-8027154
Hello,
Please review fix for Bug 8027154
bug: https://bugs.openjdk.java.net/browse/JDK-8027154
webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.01/
Best Regards,
Ramesh BG
