Hi Sergey, 1. updated Dialog default background color to SystemColor.control. http://cr.openjdk.java.net/~pkbalakr/8057574/webrev.02/
2. In WPanelPeer Initialize() method, calls to getBackground() and getForeground() behaves as follows. getBackground() call never returns null, it always returns javax.swing.plaf.ColorUIResource[r=238,g=238,b=238] i.e., "Pane.background" Color and getForeground() call always returns null, irrespective of the property set explicitly or not. Regards, Prem -----Original Message----- From: Sergey Bylokhov Sent: Friday, April 29, 2016 7:28 PM To: Prem Balakrishnan; Ambarish Rapte; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: Re: Review Request for 8057574 : inconsistent behavior for setBackground (Windows/Linux) Hi, Prem. Thanks for the new version, I just found some issues which I messed in the first version: - It seems that after the fix the Dialog will use the different background color,(SystemColor.window instead of SystemColor.control). - There is other similar code like in WPanelPeer, please check in what situation the WPanelPeer get null from the getBackground/getForeground. It seems that WColor class is used only in this WPanelPeer. On 29.04.16 8:06, Prem Balakrishnan wrote: > Hi Sergey, > > Thank you for the Review. > Update patch as per review comments. > http://cr.openjdk.java.net/~pkbalakr/8057574/webrev.01/ > > Regards, > Prem > > -----Original Message----- > From: Sergey Bylokhov > Sent: Thursday, April 28, 2016 6:16 PM > To: Prem Balakrishnan; Semyon Sadetsky; Ambarish Rapte; > awt-dev@openjdk.java.net > Subject: Re: Review Request for 8057574 : inconsistent behavior for > setBackground (Windows/Linux) > > Hi, Prem. > The fix looks fine. But please preserve the comments in > XWindowPeer.java > > On 25.04.16 9:00, Prem Balakrishnan wrote: >> Hi*,* >> >> Please review fix for JDK9, >> >> *Bug:*https://bugs.openjdk.java.net/browse/JDK-8057574 >> >> *Webrev:*http://cr.openjdk.java.net/~pkbalakr/8057574/webrev.00/ >> >> *Issue:* >> >> inconsistent behavior for setBackground (Windows/Linux) >> >> Inconsistency also exists for Foreground and Font properties across >> platforms (Win and Linux) >> >> *Fix: * >> >> Uniform behaviour is maintained by making , child component NOT to >> inherit parent properties (Background, Foreground and Font) >> >> across all the platforms(Win/Linux/Mac). >> >> *Regression and JCK tests passed without causing any regression with >> the suggested fix.* >> >> Regards, >> Prem >> > > > -- > Best regards, Sergey. > -- Best regards, Sergey.
