Hi Ambarish,
Should we put the doc change at the top or at TextField constructor
where you actually made the change for 8055197? My take it should be
done in the latter.
Also, I think you need a ccc for this.
Regards
Prasanta
On 5/12/2016 12:33 PM, Ambarish Rapte wrote:
Hi,
Please review this documentation change for awt.TextField,
Bug: https://bugs.openjdk.java.net/browse/JDK-8145284
Webrev:
http://cr.openjdk.java.net/~arapte/8145284/webrev.00/
<http://cr.openjdk.java.net/%7Earapte/8145284/webrev.00/>
What is the change:
After fix of 8055197, TextField replaces all new line
characters from input string with space characters.
This behavior is not documented, hence this change to
document the behavior.
Platform Behavior:
Mac:
AWT does not use the native NSTextField, but instead
delegates to JPasswordField, which replaces new line character with
space character.
On native Mac platform, NSTextField, is not a one line
text component.
If input string contains new line character then
NSTextField displays multiline text.
Hence we cannot consider / replicate native platform
behavior here.
Linux:
AWT delegates to peer side JPasswordField, which
replaces new line character with space character.
Windows:
The TextField terminates string after the new line
character and was reported as 8055197.
Considering the above behavior of Linux and mac,
8055197 was fixed on windows by replicating the same behavior of mac
and linux.
After the fix of 8055197, All the platforms uniformly replace new line
character with space character.
Hence the behavior should be documented.
Regards,
Ambarish
