The fix looks good to me.
Thanks,
Alexandr.
On 6/9/2016 12:43 PM, Sergey Bylokhov wrote:
+1
On 08.06.16 10:57, Hendrik Schreiber wrote:
Hey Alexandr,
On Jun 7, 2016, at 17:44, Alexandr Scherbatiy
<alexandr.scherba...@oracle.com> wrote:
I slightly updated your fix to return a multi-resolution image with
base icon size when icon size is greater than the real icon size.
This allows to draw a high-resolution icon to the same bounds on
JOptionPane.
http://cr.openjdk.java.net/~alexsch/hendrik.schreiber/8151385/webrev.01
Thanks. That looks good to me.
I have not found the solution for the native toolbar icons yet. An
icon with IDB_VIEW_SMALL_COLOR has size 16x16 on my Windows 8.1. The
GetSystemMetrics(SM_CXSMICON) returns 32. It is a question for me
should IDB_VIEW_SMALL_COLOR icon has the same size as the
GetSystemMetrics(SM_CXSMICON).
An icon with IDB_VIEW_LARGE_COLOR returns also icon with size 16x16
and the returned image contains only one quarter of the original
picture.
I left the code for the toolbar icons as it was before so it uses
low resolution IDB_VIEW_SMALL_COLOR icons.
I think it can be fixed as a separated issue.
Perhaps that’s the best approach, even though I fear that that means
it will never get fixed…
But having the other fixes in the JDK, is already some progress I
appreciate very much.
Are you going to create a new bug report?
Eventually, we simply need a more modern FileDialog. See
http://mail.openjdk.java.net/pipermail/awt-dev/2016-March/010778.html
Cheers,
-hendrik
