Re: [9] Review request for 8148984: [macosx] Chinese Comma cannot be entered using Pinyin Input Method on OS X

[dmitry markov]

Hello Alex,
Thank you for review.

Can anyone else review the fix, please?

Thanks,
Dmitry
On 23/06/2016 16:55, Alexander Potochkin wrote:

Hello Dmitry

The fix looks good!

Thanks
alexp

On 6/17/2016 15:39, dmitry markov wrote:

Hello,

Could you review a fix for jdk9, please?

    bug: https://bugs.openjdk.java.net/browse/JDK-8148984
    webrev: http://cr.openjdk.java.net/~dmarkov/8148984/webrev.00/

Problem description:

'Latin comma' character is entered in text component instead of the required 'fullwidth comma' character, when ',' character is pressed on the keyboard and Pinyin – Traditional or Simplified IM is enabled, because KeyEvent is generated instead of InputMethodEvent.

Fix:

It is necessary to generate InputMethodEvent for the characters from 'Halfwidth and Fullwidth Forms' Unicode block (U+FF00 - U+FFEF). So the method isCodePointInUnicodeBlockNeedingIMEvent() in AWTView.m should be updated.

Thanks,
Dmitry