On 6/29/2016 7:55 PM, Semyon Sadetsky wrote:
Hi Alexander,
On 6/29/2016 2:27 PM, Alexandr Scherbatiy wrote:
On 6/14/2016 5:23 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8117886
webrev: http://cr.openjdk.java.net/~ssadetsky/8117886/webrev.00/
gnome3 DE got a new DE notifications bar, so the tooltips for tray
icons have gone.
Just note about that in the TrayIcon's javadoc.
- "this is platform dependent" - may be "this behavior is
platform-dependent" would be slightly better
ok
- I am not a native speaker. For me the the "Tooltip may not be
visible" sounds better than "Tooltip may be not visible"
"Tooltip may not be visible" sounds to me as "Tooltip cannot not be
visible", while "Tooltip may be not visible" sounds like "Tooltip may
be invisible".
So, for this context the original version seems more correct to me
(also not 100% sure).
- line:204 "not" is repeated twice
ok.
Please look at the updated version:
http://cr.openjdk.java.net/~ssadetsky/8117886/webrev.01/
The fix looks good to me.
Thanks,
Alexandr.
--Semyon
Thanks,
Alexandr.
--Semyon
