Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 7/12/2016 3:12 PM, Robin Stevens wrote:

Hello Mikhail,

thanks for the review.

Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ?

I have no commit rights, so I cannot do it myself.

Thanks

Robin

On Tue, Jul 12, 2016 at 2:04 PM, Mikhail Cherkasov <mikhail.cherka...@oracle.com <mailto:mikhail.cherka...@oracle.com>> wrote:

    Looks good.


    On 12.07.2016 0:15, Robin Stevens wrote:

    Hello Mikhail,

    good catch. I adjusted the code.

    Webrev: http://cr.openjdk.java.net/~rstevens/8160941/webrev.01
    <http://cr.openjdk.java.net/%7Erstevens/8160941/webrev.01>


    Robin

    On Mon, Jul 11, 2016 at 6:08 PM, Mikhail Cherkasov
    <mikhail.cherka...@oracle.com
    <mailto:mikhail.cherka...@oracle.com>> wrote:

        On 11.07.2016 18:55, Robin Stevens wrote:

            However, that would cause an inconsistency with other
            operating systems.

        ok, but then let's simplify it:

        remove this line:
             sb.append(strings[0]);

        and start cycle from 0:
        for(int i = 0; i < strings.length; i++) {
           sb.append(strings[i]);
           sb.append(separator);
        }