Hi Rajeev,
Please review Updated patch as per review comments. Webrev: http://cr.openjdk.java.net/~pkbalakr/8144709/webrev.01/ Regards, Prem From: Rajeev Chamyal Sent: Thursday, July 21, 2016 12:36 PM To: Alexander Scherbatiy; Prem Balakrishnan; [email protected] Subject: RE: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing Hello Prem, Frame should be disposed on exceptions. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 20 July 2016 17:36 To: Prem Balakrishnan; Rajeev Chamyal; HYPERLINK "mailto:[email protected]"[email protected] Subject: Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing The fix looks good to me. Thanks, Alexandr. On 7/20/2016 12:03 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8144709 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8144709/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/8144709/webrev.00/ Issue: java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing Cause: This issue is reproducible only on windows 8 OS. Component(frame) width is set to 200, where as the minimum width obtained using ::GetSystemMetrics(SM_CXMIN) for Windows 8 is 210 (with 150% scale), hence user set width is replaced by the minimum width. Therefore the Button size obtained is 97X52 instead of 92X52. (i.e., each column is 5pixel more) Fix: frame width increased from 200 to 300 Thanks, Prem
