Hi, Rajeev.
Then the fix looks fine. Please file the separate CR to remove this unused method.

On 29.07.16 8:43, Rajeev Chamyal wrote:
Frame frame = new Frame("Test frame");
 final List myList = new List();
 myList.add("One");
 myList.add("Two");
 frame.add(myList);
 frame.setVisible(true);

AwtList::PreferredItemSize() is not called for list component but for choice 
it's called.

Regards,
Rajeev Chamyal


-----Original Message-----
From: Sergey Bylokhov
Sent: 28 July 2016 14:21
To: Rajeev Chamyal; Alexander Scherbatiy; [email protected]
Subject: Re: <Awt Dev>[9] Review Request JDK-8144594 HiDPI: awt.Choice looks 
improperly (Win 8)

On 21.07.16 18:10, Rajeev Chamyal wrote:
Hello Sergey,

This issue is not there with AwtList.

Does it mean the AwtList::PreferredItemSize() is not called or we scale the 
result of GetFontHeight() somewhere?

-----Original Message-----
From: Sergey Bylokhov
Sent: 21 July 2016 14:48
To: Rajeev Chamyal; Alexander Scherbatiy; [email protected]
Subject: Re: <Awt Dev>[9] Review Request JDK-8144594 HiDPI: awt.Choice
looks improperly (Win 8)

Should we apply the same fix to AwtList::PreferredItemSize?

On 20.07.16 11:21, Rajeev Chamyal wrote:
Hello All,



Please review the following webrev.



Bug: https://bugs.openjdk.java.net/browse/JDK-8144594

Webrev : http://cr.openjdk.java.net/~rchamyal/8144594/webrev.00



Issue : Awt choice component height is not scaling properly on a
Hidpi screen.

Fix: Height of choice is calculated from the fonts. Scaled the font
height to fix the issue.



Regards,

Rajeev Chamyal



--
Best regards, Sergey.



--
Best regards, Sergey.



--
Best regards, Sergey.

Reply via email to