Hi Sergey, I have updated the fix based on your suggestion, (i.e. add a new method). Please find a new version here: http://cr.openjdk.java.net/~dmarkov/8050478/webrev.01/ <http://cr.openjdk.java.net/~dmarkov/8050478/webrev.01/>
Thanks, Dmitry > On 24 Aug 2016, at 18:27, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: > > Then I suggest to add a new method which will generate the EXIT before > disable the window(I think it is better way?), or rename the current method > since after the fix this is not a simple nativeSetEnabled() method. > > On 24.08.16 11:03, Dmitry Markov wrote: >> Hi Sergey, >> >> Thank you for the review. >> >> Actually the event is generated when the dialog is displayed, but it is >> discarded in deliverJavaMouseEvent() function (see AWTView.m) since the >> window is already disabled. When we are going to show a modal dialog we >> disable/block previously displayed windows via setModalBlocked() method. So >> we have to generate and send MouseExited event to the window before it is >> disabled/blocked by the modal dialog. >> >> Thanks, >> Dmitry >>> On 23 Aug 2016, at 22:01, Sergey Bylokhov <sergey.bylok...@oracle.com> >>> wrote: >>> >>> Why this event is not generated by the >>> nativeSynthesizeMouseEnteredExitedEvents() when we show the dialog? >>> >>> On 23.08.16 13:27, dmitry markov wrote: >>>> Hello, >>>> >>>> Could you review a fix for jdk9, please? >>>> >>>> bug: https://bugs.openjdk.java.net/browse/JDK-8050478 >>>> webrev: http://cr.openjdk.java.net/~dmarkov/8050478/webrev.00/ >>>> >>>> Problem description: >>>> Cursor is not updated correctly after closing a modal dialog. The root >>>> cause of the issue is lack of a mouse exit event during displaying of >>>> the modal dialog. >>>> >>>> Fix: >>>> It is necessary to generate MouseExited event for the window which is >>>> going to be blocked by the modal dialog. >>>> >>>> Thanks, >>>> Dmitry >>> >>> >>> -- >>> Best regards, Sergey. >> > > > -- > Best regards, Sergey.
