Looks good to me.

Regards,
Rajeev Chamyal

-----Original Message-----
From: Sergey Bylokhov 
Sent: 12 October 2016 20:11
To: Ajit Ghaisas; Alexander Scherbatiy; awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [9] Fix for JDK-8166980 : JCK testing of 
Window.setIconImage() leads to VM crash starting approx from JDK9 b134

Looks fine.

On 12.10.16 10:10, Ajit Ghaisas wrote:
> Hi,
>
>
>
> Bug :
>
>      https://bugs.openjdk.java.net/browse/JDK-8166980
>
>
>
> Issue and Fix :
>
>      Fix for JDK-8147648
> <https://bugs.openjdk.java.net/browse/JDK-8147648> needs to be 
> corrected a little.
>
>      IconInfo::setScaledSize(int width, int height) method sets 
> scaledWidth, scaledHeight and rawLength members of IconInfo class.
>
>      In this method rawLength calculation does not consider passed in 
> width and height - rather it uses class members to calculate the 
> rawLength. This is incorrect.
>
>     The rawLength calculation is corrected as part of this fix.
>
>
>
> Webrev :
>
>      http://cr.openjdk.java.net/~aghaisas/8166980/webrev.0/
>
>
>
>     Request you to review.
>
>
>
> Regards,
>
> Ajit
>


--
Best regards, Sergey.

Reply via email to