Hi Avik, This change is done to avoid unnecessary charset lookup. No test cases fails. The fix is related to the issue https://bugs.openjdk.java.net/browse/JDK-8156099 <https://bugs.openjdk.java.net/browse/JDK-8156099>.
Regards, Manajit > On 10-Nov-2016, at 3:40 pm, Avik Niyogi <[email protected]> wrote: > > Code change looks good to me. > But just a query, any test cases that fail before the enhancement or this is > purely cosmetic? Does charset lookup affect performance? > > With Regards, > Avik Niyogi >> On 07-Nov-2016, at 8:53 pm, Sergey Bylokhov <[email protected]> >> wrote: >> >> Looks fine. >> >> On 27.10.16 14:18, Manajit Halder wrote: >>> Hi All, >>> >>> Kindly review the fix for JDK9. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8165680 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~mhalder/8165680/webrev.00/ >>> >>> Issue: >>> [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java >>> >>> Fix: >>> Improved handling of UTF_8 characters by avoiding unnecessary lookup. >>> >>> Regards, >>> Manajit >> >> >> -- >> Best regards, Sergey. >
