I approve On Tue, Dec 6, 2016 at 4:21 AM, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: > Hi, Sergey. > Please take a look to the updated version (the names are updated): > http://cr.openjdk.java.net/~serb/4419271/webrev.03 > >> 28 нояб. 2016 г., в 7:01, Sergey Malenkov <malen...@gmail.com> написал(а): >> >> The fix looks good, but we realized that the direction is not always changed. >> For example, Windows from VirtualBox on Mac. >> >> - jint scrollLines = 3; >> + jint toScroll = 3; >> >> - UINT platformLines; >> + UINT platformUnits; >> >> Also I prefer to use similar names for this variables as before. >> For example, scrollUnits instead of toScroll >> >> >> >> On Thu, Nov 24, 2016 at 4:32 PM, Alexandr Scherbatiy >> <alexandr.scherba...@oracle.com> wrote: >>> >>> The fix looks good to me. >>> >>> Thanks, >>> Alexandr. >>> >>> >>> On 11/23/2016 5:20 PM, Sergey Bylokhov wrote: >>>> >>>> Hello. >>>> >>>> Please review the fix for jdk9. >>>> >>>> Support of WM_MOUSEHWHEEL for Swing was added (AWT components were not >>>> touched), which mostly the code symmetric to the WM_MOUSEWHEEL, except that >>>> I changed the direction to align it in Swing and OS. It seems that this >>>> functionality does not work on linux as well, at least I was not able to >>>> enable it. Will file a separate bug for jdk on linux. >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-4419271 >>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/4419271/webrev.02 >>>> >>> >> >> >> >> -- >> Best regards, >> Sergey A. Malenkov >
-- Best regards, Sergey A. Malenkov
