Re: [9] Review request for 8171949: [macosx] AWT_ZoomFrame Automated tests fail with error: The bitwise mask Frame.ICONIFIED is not setwhen the frame is in ICONIFIED state

[Semyon Sadetsky]

+1

--Semyon


On 12/28/2016 4:53 PM, Dmitry Markov wrote:

Thank you, Sergey!
Looking for the second +1 from someone else.

Thanks,
Dmitry

On 28 Dec 2016, at 16:43, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote:

Looks fine.

Hello,

Could you review a fix for jdk9, please?

        bug: https://bugs.openjdk.java.net/browse/JDK-8171949
        webrev: http://cr.openjdk.java.net/~dmarkov/8171949/webrev.00/

Problem description:
Current implementation of CPlatformWindow.orderAboveSiblings() performs 
ordering for iconified windows. That causes the following problem: if window’s 
state set to ICONIFIED via setExtendedState() method, the window moves to 
ICONIFIED state, but right after that it moves back to the previous state, 
(i.e. the invocation of setExtendedState() does not have any effect).

Fix:
CPlatformWindow.orderAboveSiblings() should NOT perform ordering for the 
windows which are already in ICONIFIED state or when iconify operation, (i.e 
moving to ICONIFIED state is in progress).


Thanks,
Dmitry