Hi Ambarish, I've made the suggested changes
http://cr.openjdk.java.net/~srastogi/rahul/8137087/8137087/webrev.01/ -Regards, Rahul Singh On 2017-02-07 2:17 PM, Ambarish Rapte wrote:
Hi Rahul, I think the line number 139 can be removed. Similarly please remove the 2 new empty lines. No: 158 & 247. Regards, Ambarish -----Original Message----- From: Yuri Nesterenko Sent: Tuesday, January 31, 2017 2:52 PM To: Rahul Singh; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh OK with me. TMP variable would be still in POSIX notation but it seems not necessary here. -yan On 01/24/2017 09:44 AM, Rahul Singh wrote:Hi All, Kindly review the fix for the bug: JDK-8137087 <https://bugs.openjdk.java.net/browse/JDK-8137087> [TEST BUG] The test java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh needed few changes to be run in the Cygwin Environment. Bug Link: https://bugs.openjdk.java.net/browse/JDK-8137087 The webrev is : http://cr.openjdk.java.net/~srastogi/rahul/8137087/webrev.00/ Regards, Rahul Singh
