Hi Semyon,
Fix looks good to me.
Regards,
Ambarish
-----Original Message-----
From: Semyon Sadetsky
Sent: Friday, April 14, 2017 3:15 AM
To: awt-dev
Subject: <AWT Dev> [10] Review request for 8132299: Test
java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails on Linux
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8132299
webrev: http://cr.openjdk.java.net/~ssadetsky/8132299/webrev.00/
The issue itself is a linux/solaris specific. Alt-Gr modifier bit (1<<5) is not
set in the KeyPress event which is sent by the closing key in the combination
(which action should be modified). On platforms other than linux/solaris the
ModifierRobotKeyTest.java successfully passes but takes a lot of time to
execute.
Linux has two special keys assigned for 5th column as xmodmap command
report:
mod5 ISO_Level3_Shift (0x5c), Mode_switch (0xcb)
Java implementation uses Mode_switch native key for mapping to Alt-Gr.
But Mode_switch is not processed as a modifier key by the native platform while
ISO_Level3_Shift is processed as modifier. So, changing this mapping solves the
problem.
Also, the ModifierRobotKeyTest.java is modified in the fix to decrease its
execution time.
--Semyon
