Hi Krishna, The fix looks good.
A small suggestion: please maintain the line length to 80 characters. You can do that just before pushing the changes to repo. Regards, Ambarish From: Krishna Addepalli Sent: Friday, July 14, 2017 5:17 PM To: [email protected]; AJIT.GHAISAS; Sergey Bylokhov; Praveen Srivastava Subject: <AWT Dev> [10][JDK-8027154] [TESTBUG] Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails Hi All, Please review the fix for test bug: Bug : JDK-8027154 HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8027154";<https://bugs.openjdk.java.net/browse/JDK-8027154> JDK 10 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/Krishna/8027154/webrev00/"http://cr.openjdk.java.net/~pkbalakr/Krishna/8027154/webrev00/ Summary: The test intends to check the mouse move on Frame2, which is drawn in the MouseMove callback for Frame1. However, the code wrongly asserts for the expected mouse position on Frame2, which was just created. Also, Frame2 has no callback registered for MouseMove, which is leading to different behaviors on different platforms. On Windows and Linux, the assertion is thrown for Mouse Position whereas on Mac, a NullPointerException is thrown. After moving the code into the callback for Frame2, the test passes on all the platforms. Thanks, Krishna
