Thank you for the fix.
Looks fine.

----- goetz.lindenma...@sap.com wrote:

> Hi,
> 
> I added more headful tests that are only run on windows.  I also added
> 
> some @requires os=windows where obvious.
> I would appreciate a review!
> http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/
> 
> Best regards,
>   Goetz.
> 
> > -----Original Message-----
> > From: awt-dev [mailto:awt-dev-boun...@openjdk.java.net] On Behalf
> Of
> > Lindenmaier, Goetz
> > Sent: Freitag, 4. August 2017 13:53
> > To: awt-dev@openjdk.java.net
> > Subject: Re: <AWT Dev> RFR(M): 8185500: [TESTBUG] Add keywords
> > headful/printer in java/awt and javax tests.
> > 
> > Hi,
> > 
> > I added another approx. 20 tests which are headful but are run only
> on mac.
> >
> http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/
> > 
> > Best regards,
> >   Goetz.
> > 
> > > -----Original Message-----
> > > From: Lindenmaier, Goetz
> > > Sent: Mittwoch, 2. August 2017 11:13
> > > To: awt-dev@openjdk.java.net
> > > Subject: RFR(M): 8185500: [TESTBUG] Add keywords headful/printer
> in
> > > java/awt and javax tests.
> > >
> > > Hi,
> > >
> > > I looked at all the remaining tests failing in our test
> environment, and I
> > > think I have now identified the last set of headful tests that
> lack the
> > > @key headful tag.
> > >
> > > Also, I identified a row of tests that require a printer. For
> these I introduce
> > > the new keyword 'printer' and marked them accordingly.
> > >
> > > A few tests threw NullPointerException in the finalizer if run
> headless,
> > > I fixed that, too.
> > >
> > > Please review this change:
> > >
> > > http://cr.openjdk.java.net/~goetz/wr17/8185500-
> > headlessKey/webrev.01/index.html
> > >
> > > Thanks and best regards,
> > >   Goetz.

Reply via email to