Looks fine.
On 10/6/17 06:43, Sreeprakash Sreedharan wrote:
Hi,
Please review this webrev for JDK-8u backport.
Webrev: http://cr.openjdk.java.net/~ssreedharan/8180370/jdk8u-dev/webrev.00/
Main Bug: https://bugs.openjdk.java.net/browse/JDK-8180370
JDK10 review thread:
http://mail.openjdk.java.net/pipermail/awt-dev/2017-June/012881.html
JDK10 changeset: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/7d3e0c5b5e25
The patch from JDK10 was not applied cleanly.
Changes were made only in AWTView.m
The JDK10 patch was using the NSMutableString /useString/ length to
ensure that the fKeyEventsNeeded is reset only for a non-zero length string.
This NSMutableString /useString/ is however not available in JDK8u-dev.
This variable was added as part of fix for BUG JDK-8148555: [macosx] An
uncaught exception was raised entering Emoji into JTextArea.
This however has not been backported to JDK8u-dev.
So replaced the use of NSMutableString /useString/ length check with a
check using the existing variables /utf16Length/ and /utf8Length/.
This will not cause an issue even if JDK-8148555 is eventually backported.
I have tested out all the relevant Swing and AWT JTREG tests.
Also, ensured that there are no failures related to this on JPRT (both
west and Stockholm) Queues.
Regards,
Sreeprakash
--
Best regards, Sergey.
