+1
On 02/01/2018 02:25, Ajit Ghaisas wrote:
Looks good. +1.
Minor nit-
1.There should be a space between “if” and “(“
2.Second string concatenation (+) in System.out.println is not needed
You can fix these while pushing the changeset.
Regards,
Ajit
*From:*Shashidhara Veerabhadraiah
*Sent:* Tuesday, January 02, 2018 9:33 AM
*To:* Sergey Bylokhov; Philip Race; [email protected]
*Subject:* Re: <AWT Dev> [10] JDK-8193468: [PIT][TEST BUG]:
java/awt/FileDialog/MoveToTrashTest.java fails on Linux
Hi All, Please review this.
Thanks and regards,
Shashi
*From:*shashidhara veerabhadraiah
*Sent:* Saturday, December 16, 2017 10:11 AM
*To:* Sergey Bylokhov <[email protected]
<mailto:[email protected]>>; Philip Race
<[email protected] <mailto:[email protected]>>;
[email protected] <mailto:[email protected]>
*Subject:* <AWT Dev> [10] JDK-8193468: [PIT][TEST BUG]:
java/awt/FileDialog/MoveToTrashTest.java fails on Linux
Hi, Please review a test only fix for a regression introduced under the
original bug: https://bugs.openjdk.java.net/browse/JDK-8190515.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193468
Webrev: http://cr.openjdk.java.net/~sveerabhadra/8193468/webrev.00/
Fix: A file move to trash action is not supported on some platforms and
was missing in the initial implementation. Now there is a check being
introduced to verify if this is action is permitted on this particular
platform or not and based on that the test proceeds.
Please note that JDK target version is put as 10 and this is as per the
bug description and if this needs to be changed to 11, please let me
know. I assume that when this bug was created, right JDK version was put
across.
Thanks and regards,
Shashi
--
Best regards, Sergey.
