Posting this to awt-dev, too. This change adapts some tests to run on properly on aix or s390: http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/
Best regards, Goetz. > -----Original Message----- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Mittwoch, 17. Januar 2018 12:55 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Volker Simonis > <volker.simo...@gmail.com> > Cc: core-libs-...@openjdk.java.net; Baesken, Matthias > <matthias.baes...@sap.com> > Subject: Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms. > > Hi Goetz, > > test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/OS.java > > I thought this was for AIX recognition not OS/400 ? ;-) > > Otherwise the AIX changes seem okay. Thought AWT tests should be > reviewed on awt-dev. > > Cheers, > David > > On 17/01/2018 9:39 PM, Lindenmaier, Goetz wrote: > > Hi, > > > > Volker, thanks for your review. Could someone else please have a > > quick look at this simple fix? > > > > Updated webrev with fixed BadPluginConfigurationTest: > > http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/ > > > > Best regards, > > Goetz. > > > >> -----Original Message----- > >> From: Volker Simonis [mailto:volker.simo...@gmail.com] > >> Sent: Dienstag, 16. Januar 2018 19:28 > >> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > >> Cc: Baesken, Matthias <matthias.baes...@sap.com>; core-libs- > >> d...@openjdk.java.net > >> Subject: Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to > platforms. > >> > >> Hi Goetz, > >> > >> you change looks good. Just one minor nit (no need for a new webrev if > >> you agree with my fix :) > >> > >> In BadPluginConfigurationTest.sh you first check if 'mktemp' exists as > >> file. This is a useless check because there won't be a file "mktemp" > >> in the current exectution directory of the shell script, even if the > >> "mktemp" exists domehwere in the PATH. To check for the existence of a > >> "mktemp" executable you can use the "type" command: > >> > >> type mktempp> /dev/null 2>&1 > >> > >> if ! [ $? -ne 0 ] ; then > >> MKTEMP="/opt/freeware/bin/mktemp" > >> fi > >> > >> Thanks for finally fixing this, > >> Volker > >> > >> > >> On Mon, Jan 15, 2018 at 12:12 PM, Lindenmaier, Goetz > >> <goetz.lindenma...@sap.com> wrote: > >>> Hi Matthias, > >>> > >>> I didin't mean to do any changes for other platforms, so > >>> I reverted the part you pointed out: > >>> http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.02/ > >>> > >>> But scanning through all the scripts: > >>> Sometimes PS on Cygwin is ';' and sometimes it is ':'. Strange ... > >>> > >>> Best regards, > >>> Goetz. > >>> > >>>> -----Original Message----- > >>>> From: Baesken, Matthias > >>>> Sent: Montag, 15. Januar 2018 09:03 > >>>> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; core-libs- > >>>> d...@openjdk.java.net > >>>> Subject: RE: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to > >> platforms. > >>>> > >>>> Hi Goetz, change looks good except > >>>> > >>>> test/jdk/sun/security/tools/keytool/i18n.sh > >>>> > >>>> where the Cygwin PS setting has been changed from ; to : (probably > this > >>>> was not intended) : > >>>> > >>>> PS=":" > >>>> FS="/" > >>>> ;; > >>>> - CYGWIN* ) > >>>> - NULL=/dev/null > >>>> - PS=";" > >>>> > >>>> > >>>> (not a Reviewer however). > >>>> > >>>> Best regards, Matthias > >>>> > >>>> > >>>> > >>>>> -----Original Message----- > >>>>> From: Lindenmaier, Goetz > >>>>> Sent: Mittwoch, 10. Januar 2018 09:23 > >>>>> To: core-libs-...@openjdk.java.net > >>>>> Cc: Baesken, Matthias <matthias.baes...@sap.com> > >>>>> Subject: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to > platforms. > >>>>> > >>>>> Hi, > >>>>> > >>>>> this change adapts a row of jtreg tests to AIX. > >>>>> Shell tests often switch over all OSes, here the case for AIX was > >>>>> missing. PKCSTest needs to know where the libs are on s390. > >>>>> > >>>>> Please review. > >>>>> http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev/ > >>>>> > >>>>> Best regards, > >>>>> Goetz.
