The change of local types declarations looks reasonable, but I am not
sure that C99 will be supported by all compilers which will be used to
build jdk where this fix will be used.
I suggest to simplify the fix and add only one null check to it.
On 01/02/2018 04:06, Krishna Addepalli wrote:
Please review a fix for JDK-8171000:
The crash happens since XGetImage can return NULL in case of Wayland,
which doesnot permit reading screen pixels outside the owning window.
Added a null check to prevent the same, and also refactored and removed
unnecessary code to make the function simpler.
Best regards, Sergey.