Hi,
I'm have no insight into why
-vmoptions:"-Dsun.java2d.uiScale=10"
would not get passed to at least the parent program, but I assume that if we
are running on a hidpi setup
there is no need to explicitly pass it to parent or child.
The basic focus of the fix -ensuring we always dispose the frame - seems fine
to me.
-phil.
On 02/15/2018 11:33 PM, Jayathirth D V wrote:
Hi Sergey,
Strangely I tried the same -vmoptions:"-Dsun.java2d.uiScale=3" thing today and using
System.getProperty("sun.java2d.uiScale") I am able to get the value inside test case. So
I have modified the test case to pass scale value to ProcessCommunicator.executeChildProcess() and
also I made some indentation changes in test case.
Please find updated webrev for review:
http://cr.openjdk.java.net/~jdv/8197926/webrev.02/
Thanks,
Jay
-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, February 16, 2018 3:28 AM
To: Jayathirth D V
Cc: awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [AWT Dev] [11] RFR JDK-8197926:
java/awt/dnd/ImageTransferTest/ImageTransferTest.java doesnt close the windows in
HiDPI setting
Hi, Jay.
I tried different failure scenarios inside test like making comparing
images fail but all the times frames are getting disposed.
Could you please elaborate in which scenario exactly you are seeing
frame not getting disposed?
I run the version of the test before your fix, and it leaves one of the frame
of the screen.
But I have still added explicit frame.dispose() at places to make sure
that we dispose the created frames.
Please find updated webrev for review:
http://cr.openjdk.java.net/~jdv/8197926/webrev.01/
Also in continuation to what we discussed offline, I used
-vmoptions:"-Dsun.java2d.uiScale=2" to pass to jtreg from command
prompt. But in this case also System.getProperty("sun.java2d.uiScale")
returned null in test case. So I was not able to pass uiScale
mentioned in command prompt to ProcessCommunicator in test case.
I tested it using this command line:
../jtreg/bin/jtreg -vmoptions:"-Dsun.java2d.uiScale=10" -verbose:summary -a -nr
-jdk:./build/windows-x64/images/jdk/
open/test/jdk/java/awt/dnd/ImageTransferTest/ImageTransferTest.java
Plus this change in the test:
public static void main(String[] arg) throws Exception {
+ String prop = System.getProperty("sun.java2d.uiScale");
+ System.err.println(prop);
It prints 10 in the log.
